feat: add (optional) defaultValue parameters to firstValueFrom and lastValueFrom #6204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds an optional
defaultValue
parameter tofirstValueFrom
andlastValueFrom
. The parameters are added using an overload to avoid this issue (for some usage, at least).The
first
andlast
operators both support defaults and I see no reason whyfirstValueFrom
andlastValueFrom
should not do the same. Sure, you could applydefaultIfEmpty
to the source, but you say the same forfirst
andlast
. And, IMO, includingdefaultValue
in the signatures serves as a reminder that the functions expect a value and that not having an available value is an unexpected/error situation.Also, supporting default values would make implementing a user-land equivalent that resolves with an
Option
straightforward. (IMO, introducing aOption
isn't something we should do while there are bunch of APIs that throw for empty sources.)Related issue (if exists): Nope