docs: more breaking changes #6313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds more breaking changes that are missing from the v6/v7 changes doc:
There were breaking changes made to
auditand, therefore,auditTimein fix(audit, auditTime): audit and auditTime emit last value after source completes #5799That PR description did not include 'BREAKING CHANGE', so, AFAICT, the changes weren't mentioned in the CHANGELOG.
Prior to separating the
fromEventsignatures by target type - in refactor: separate fromEvent signatures by target type #6214 - it was possible to pass options to APIs that didn't support them. (The options are ignored in thefromEventimplementation for targets that don't support them.) Attempting to do this in v7 will effect a TypeScript compilation error.In fix: finalize after unsubscription from source #5433,
finalizewas changed so that it unsubscribes from its source before it calls the specified callback.Related issue (if exists): Nope