Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make share, publish, et al. operator calls referentially transparent #6410

Merged
merged 12 commits into from
May 21, 2021
Merged

fix: make share, publish, et al. operator calls referentially transparent #6410

merged 12 commits into from
May 21, 2021
+261 −94

Commits on May 20, 2021

  1. fix(publish,publishReplay): resolve sharing Subject 

    change publish operator to use factory
change publishReplay operator to not share ReplaySubject
fixes issue ReactiveX#5411
    @e-davidson @cartant
    e-davidson authored and cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    b998fa0 View commit details
    Browse the repository at this point in the history

  2. test: rearrange tests

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    f0e13c0 View commit details
    Browse the repository at this point in the history

  3. test: add failing ref transparency tests

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    47376dc View commit details
    Browse the repository at this point in the history

  4. fix(publishBehavior): make ref transparent

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    e0b4e57 View commit details
    Browse the repository at this point in the history

  5. fix(publishLast): make ref transparent

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    2ccae8c View commit details
    Browse the repository at this point in the history

  6. test: add failing ref transparency tests

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    a7879a1 View commit details
    Browse the repository at this point in the history

  7. fix(share): make ref transparent

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    877b379 View commit details
    Browse the repository at this point in the history

  8. chore: add a comment

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    854abf6 View commit details
    Browse the repository at this point in the history

  9. test: change descriptions and add comments

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    17dc704 View commit details
    Browse the repository at this point in the history

  10. refactor: destructure options outside of op func

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    56919fa View commit details
    Browse the repository at this point in the history

  11. chore: use consistent terminology in comments

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    a69cff9 View commit details
    Browse the repository at this point in the history

  12. test: use consistent terminology

    @cartant
    cartant committed May 20, 2021
    Configuration menu
    Copy the full SHA
    da2037e View commit details
    Browse the repository at this point in the history