Feature/share notifier observable input #6430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backbone87
commented
May 28, 2021
| @@ -224,15 +231,15 @@ export function share<T>(options: ShareConfig<T> = {}): MonoTypeOperatorFunction | |||
| dest.complete(); | |||
| }, | |||
| }); | |||
| from(source).subscribe(connection); | |||
| source.subscribe(connection); | |||
There was a problem hiding this comment.
i dont know why a from was here, since it is an observable already, but if at all we should probably use innerFrom?
|
CI fail seems unrelated |
backbone87
force-pushed
the
feature/share-notifier-observable-input
branch
from
ee727fe to
520c4ce
Compare
|
anything left to move this forward? |
benlesh
reviewed
Aug 5, 2021
spec-dtslint/operators/share-spec.ts
Outdated
| share({ | ||
| resetOnError: () => new Promise(() => {}), | ||
| resetOnComplete: () => new Promise(() => {}), | ||
| resetOnRefCountZero: () => new Promise(() => {}), |
There was a problem hiding this comment.
Can we use something better than unresolved forever promises here? haha. I mean, I know it's just tests, but this is a leak.
There was a problem hiding this comment.
Out of curiosity: is it indeed a leak? No references are being held to anything?
benlesh
requested changes
Aug 5, 2021
backbone87
force-pushed
the
feature/share-notifier-observable-input
branch
from
520c4ce to
7834c31
Compare
|
review changes & rebased |
|
whats blocking this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Accept
ObservableInputas return values from notifier factories and documentShareConfigdefault values.