chore: add disambiguateByNonOperator disambiguator #6540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben encountered the same failing test - in CI - recently and was unable to get it to fail locally. Rerunning the CI tests 'fixed' the problem there and here, too. |
|
@cartant thanks! |
benlesh
approved these changes
Aug 5, 2021
|
Thank you @jakovljevic-mladen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all errors when building docs. It add new disambiguator that removes duplicates when building docs. Since most of the operators are now exported in both root (
'rxjs') and/operatorspaths, a lot of duplicates were created. With this disambiguator, precedence is given to those from'index'module ('rxjs'import site).Also, existing
disambiguateByDeprecateddisambiguator is changed for this reason: many duplicated documents that were deprecated are filtering all existing documents with this disambiguator which lead to yet another error saying that no documents are found.Side note: for couple of months now, running
npm run docshas always slightly modified/concatAll.svgfile, which I committed now - this is totally unrelated to the issue solved with this PR. If not needed, please let me know so I can remove it.Related issue (if exists):
Closes #6539