Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forEach): properly unsubs after error in next handler #6677

Merged
merged 1 commit into from
Dec 6, 2021
Merged

fix(forEach): properly unsubs after error in next handler #6677

merged 1 commit into from
Dec 6, 2021

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Nov 15, 2021

fixes #6676

@benlesh benlesh added 7.x Issues and PRs for version 7.x 8.x Issues and PRs for version 8.x labels Nov 15, 2021
@benlesh benlesh merged commit b9ab67d into ReactiveX:master Dec 6, 2021
@benlesh benlesh deleted the fix-forEach-sync-error-in-next-handler branch December 6, 2021 23:38
benlesh added a commit that referenced this pull request Dec 6, 2021
@benlesh
fix(forEach): properly unsubs after error in next handler (#6677)
4c675b8 
fixes #6676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
7.x Issues and PRs for version 7.x 8.x Issues and PRs for version 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forEach does not unsubscribe appropriately when next handler throws on synchronous emissions
2 participants
@benlesh @cartant