refactor: add createOperatorSubscriber abstraction
#6804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply hides the creation of `new OperatorSubscriber` in a function called `createOperatorSubscriber`. This is part of a larger plan to: 1. Productize our internal means of creating operators so other folks can use it. (this is just the first step, I do not plan on exposing `createOperatorSubscriber` at this time). The idea is to move away from using classes all over our operators for both minification reasons and because then later, when we productize things, we don't have to export classes that people will try to subclass. 2. Make it easier to refactor the class underpinning our operators by abstracting it away NOTE: This does not attempt to change anything about the special case in `groupBy`, which will require some thought.
benlesh
added a commit
to benlesh/rxjs
that referenced
this pull request
Feb 7, 2022
Adds a special case to `OperatorSubscriber` to support `groupBy`. Related: ReactiveX#6805 ReactiveX#6803 ReactiveX#6804
benlesh
added
7.x
cartant
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply hides the creation of
new OperatorSubscriberin a function calledcreateOperatorSubscriber.This is part of a larger plan to:
createOperatorSubscriberat this time). The idea is to move away from using classes all over our operators for both minification reasons and because then later, when we productize things, we don't have to export classes that people will try to subclass.NOTE: This does not attempt to change anything about the special case in
groupBy, which will require some thought.Related: #6803