Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(fromEvent): update the example to match the actual API #7246

Merged
merged 1 commit into from
Apr 12, 2023
Merged

docs(fromEvent): update the example to match the actual API #7246

merged 1 commit into from
Apr 12, 2023

Conversation

demensky
Copy link
Contributor

@demensky demensky commented Apr 9, 2023 •
edited by jakovljevic-mladen
Loading

Updates the example according to the API.

Related issue (if exists):
Closes #7245

jakovljevic-mladen
jakovljevic-mladen reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a minor suggestion so that this example becomes fully functional.

src/internal/observable/fromEvent.ts Outdated Show resolved Hide resolved
@demensky demensky force-pushed the fromEvent-capture branch from 39adabb to aafa3ab Compare April 10, 2023 15:04
jakovljevic-mladen
jakovljevic-mladen approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakovljevic-mladen
Copy link
Member

@demensky, can you please update PR by changing target to master branch? After merge, I usually manually cherry-pick to 7.x, I don't do that the other way around.

@demensky demensky changed the base branch from 7.x to master April 11, 2023 17:47
@demensky demensky marked this pull request as draft April 11, 2023 17:48
@demensky demensky force-pushed the fromEvent-capture branch from aafa3ab to b25c85d Compare April 11, 2023 17:56
@demensky demensky force-pushed the fromEvent-capture branch from b25c85d to 2708a69 Compare April 11, 2023 18:15
@demensky demensky marked this pull request as ready for review April 11, 2023 18:15
jakovljevic-mladen
jakovljevic-mladen approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for changing target to the master.

@jakovljevic-mladen jakovljevic-mladen linked an issue Apr 12, 2023 that may be closed by this pull request
FromEvent Docs: No overload matches this call. #7245
Closed
@jakovljevic-mladen jakovljevic-mladen added 7.x Issues and PRs for version 7.x 8.x Issues and PRs for version 8.x labels Apr 12, 2023
@jakovljevic-mladen jakovljevic-mladen merged commit 3812d16 into ReactiveX:master Apr 12, 2023
jakovljevic-mladen pushed a commit that referenced this pull request Apr 12, 2023
@demensky @jakovljevic-mladen
docs(fromEvent): update the example to match the actual API (#7246)
e88a266 
Resolves: #7245
(cherry picked from commit 3812d16)
@scottwad scottwad mentioned this pull request Jun 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakovljevic-mladen jakovljevic-mladen jakovljevic-mladen approved these changes

Assignees
No one assigned
Labels
7.x Issues and PRs for version 7.x 8.x Issues and PRs for version 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FromEvent Docs: No overload matches this call.
2 participants
@demensky @jakovljevic-mladen