fix(catch): fix catch to dispose old subscriptions #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.destination.complete(); | ||
| } | ||
|
|
||
| _unsubscribe() { |
There was a problem hiding this comment.
According to test coverage, yes it is. _unsubscribe() is overriding Subscription._unsubscribe(), which is called inside Subscription.unsubscribe().
There was a problem hiding this comment.
Ah, didn't aware it's inherited from Subscription. thought it's inherited from Subscriber and tried to look Subscriber::_unsubscribe() instead.. my bad. :(
Fix catch operator to not have anymore a shared underlying Subscription, and instead reset the subscription for each new observable replacing the caught error. This fixes a potential memory leak if catch is used as an infinite retry, because subscriptions would be retained since the beginning, and would increasing each time a catch is performed. Resolves issue ReactiveX#763.
|
Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON PR #764 MERGED FIRST.
Fix catch operator to not have anymore a shared underlying Subscription, and instead reset the
subscription for each new observable replacing the caught error. This fixes a potential memory leak
if catch is used as an infinite retry, because subscriptions would be retained since the beginning,
and would increasing each time a catch is performed.
Resolves issue #763.