Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler rename #914

Merged
merged 2 commits into from
Dec 8, 2015
Merged

Scheduler rename #914

merged 2 commits into from
Dec 8, 2015

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Dec 7, 2015

This is just a straight renaming, per discussions on #838

The result is as follows:

RxJS 4 RxJS 5
currentThread queue
default asap

Additional schedulers are still to be implemented.

@benlesh
Copy link
Member Author

benlesh commented Dec 7, 2015

I know some people weren't enthused about the asap name. But I settled on it, in lieu of variants of names with "job" in it (per @zenparsing and @jhusain telling me that the TC39 refers to micro task queues as "jobs")... this is because _googling "RxJS job scheduler" or "RxJS job" or the like would yield horrendous results.

On the other hand, googling "javascript asap" or the like, yields extremely relevant results even today.

@staltz
Copy link
Member

staltz commented Dec 7, 2015

D:

@benlesh
Copy link
Member Author

benlesh commented Dec 7, 2015

Naming these things sucks. haha. I don't expect everyone to be happy with the choices. Hell, I'm not even happy with them, completely.

Just need to make a choice and keep moving.

@kwonoj
Copy link
Member

kwonoj commented Dec 8, 2015

👍

@benlesh
feat(QueueScheduler): rename ImmediateScheduler to QueueScheduler
66eb537 
- rename ImmediateScheduler to QueueScheduler
- rename ImmediateAction to QueueAction
- rename Rx.Scheduler.immediate to Rx.Scheduler.queue

BREAKING CHANGE: Immediate scheduler is now Queue scheduler
related #838
@benlesh
feat(AsapScheduler): rename NextTickScheduler to AsapScheduler
3255fb3 
- NextTickScheduler is now AsapScheduler
- NextTickAction is now AsapAction
- Rx.Scheduler.nextTick is now Rx.Scheduler.asap

This was done to more clearly define in a concise way what the scheduler is doing
if you google 'asap javascript', a library that does the same thing comes up as the
top result.

BREAKING CHANGE: Rx.Scheduler.nextTick is now Rx.Scheduler.asap
closes #838
@benlesh benlesh merged commit 3255fb3 into ReactiveX:master Dec 8, 2015
@benlesh benlesh deleted the scheduler-rename branch April 27, 2016 17:20
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benlesh @staltz @kwonoj