Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js considered harmful, need alternate testing/ci solution #39

Closed
dhdaines opened this issue Nov 30, 2022 · 1 comment
Closed

Node.js considered harmful, need alternate testing/ci solution #39

dhdaines opened this issue Nov 30, 2022 · 1 comment
Milestone

Comments

@dhdaines
Copy link
Contributor

There is no good reason to compile to WebAssembly and run under Node.js aside from testing, and doing so makes everything more complicated and prevents us from easily packaging SoundSwallower as an ES6 module (though maybe that bug is fixed: emscripten-core/emscripten#17915)

Still, there isn't any good reason to do it. SoundSwallower is always used via Python for offline, command-line, etc, and this makes sense since all the code stuff for manipulating speech data and models is there anyway.

The problem is that we need to test the JavaScript code, and Node.js is pretty useful for that. There are I think like 15 different solutions for providing an automated test environment that looks like the browser, all of them have cutsey names and probably icons too, and I have no clue.

So probably I should figure this out.

@dhdaines
Copy link
Contributor Author

Figured this out, though it is not too pretty, in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant