Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package SoundSwallower as ES6 module #40

Closed
dhdaines opened this issue Nov 30, 2022 · 3 comments
Closed

Package SoundSwallower as ES6 module #40

dhdaines opened this issue Nov 30, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@dhdaines
Copy link
Contributor

It seems that this is possible, so we should do it.

@dhdaines dhdaines added this to the 0.5.0 milestone Nov 30, 2022
@dhdaines
Copy link
Contributor Author

dhdaines commented Nov 30, 2022

This should work with the latest Emscripten (see emscripten-core/emscripten#17915 (comment) for instructions)

BUT, I need to remove various uses of require from the code, which are all related to the need to run under Node.js:

But see also #39 because supporting Node is not actually desireable

@dhdaines
Copy link
Contributor Author

Or, actually, should use https://github.com/lquixada/cross-fetch

@dhdaines dhdaines added the enhancement New feature or request label Dec 1, 2022
@dhdaines
Copy link
Contributor Author

Fixed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant