Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge new features from PocketSphinx 5 (and simplify things) #27

Merged
merged 136 commits into from
Nov 4, 2022

Conversation

dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Nov 4, 2022

Pull in a ton of changes from PocketSphinx 5.0.0:

  • WebRTC VAD and Endpointer based on it (Javascript API is not fully mature here)
  • Direct get/set CMN API instead of hacking the config
  • Eliminate overflows in GMM computation
  • Compile JSGF to correct (but wasteful) FSGs
  • Interact with configuration and results using JSON (exclusively, in JavaScript)
  • Subword alignments

Then do ... some other things:

  • Eliminate "pocketsphinx" names from the API and drop any pretense at backward-compatibility
  • Replace superfluous Cython classes with namedtuples
  • Consistenly report start and duration in Python and JavaScript segmentations (C will follow)
  • Remove FSG model and Config classes from JavaScript API, making code more compact and eliminating memory leaks
  • Grow feature buffers by default to make two-pass alignment work as expected

@dhdaines dhdaines requested review from joanise and roedoejet November 4, 2022 00:21
@dhdaines dhdaines merged commit ead27e7 into master Nov 4, 2022
@joanise
Copy link
Member

joanise commented Nov 4, 2022

Wow, yeah, this is a huge PR. I wouldn't be able to give you much useful feedback if I tried... Thanks for making this update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants