fix: extremely bogus state align code

TODO.md

@@ -1,9 +1,20 @@
 Roadmap:
 
+- 0.4.x: Fix some problems
+  - Absence of mdef_convert
+    - Make a general model conversion tool
+    - Allows us flexibility in model implementation for future
+  - Documentation deficiencies
+    - Lack of example for endpointer
+  - Lack of adapter for endpointer (WebAudio, etc)
+  - Lack of web audio format support
+
+- 0.5.x: Improve performance/usability
+  - Phone input/output as IPA
+  - Optimize JSGF compiler
+
 - 1.0: Finalize API
   - ES6 module (possibly separate for Node vs. Web)
-  - Optimize JSGF compiler
-  - Support IPA dictionaries
   - Improve Endpointer/VAD
   - Clearly define use cases and restructure API for them
     - Live: feed data asynchronously, check results synchronously or emit events

include/soundswallower/state_align_search.h

@@ -59,7 +59,7 @@ extern "C" {
  * History structure
  */
 struct state_align_hist_s {
-    uint16 id;
+    int32 id;
     int32 score;
 };
 typedef struct state_align_hist_s state_align_hist_t;

src/state_align_search.c

@@ -226,7 +226,7 @@ state_align_search_finish(search_module_t *search)
     /* Best state exiting the last cur_frame. */
     last.id = cur.id = hmm_out_history(final_phone);
     last.score = hmm_out_score(final_phone);
-    if (last.id == 0xffff) {
+    if (last.id == -1) {
         E_ERROR("Failed to reach final state in alignment\n");
         return -1;
     }
@@ -235,6 +235,10 @@ state_align_search_finish(search_module_t *search)
     /* Look at frame - 2 because we track transitions, I think */
     for (cur_frame = sas->frame - 2; cur_frame >= 0; --cur_frame) {
 	cur = sas->tokens[cur_frame * sas->n_emit_state + cur.id];
+        if (cur.id == -1) {
+            E_ERROR("Alignment failed in frame %d\n", cur_frame);
+            return -1;
+        }
         /* State boundary, update alignment entry for next state. */
         if (cur.id != last.id) {
             itor = alignment_iter_goto(itor, last.id);