Make the API less asynchronous #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines async/await are not coroutines
dhdaines
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps it's common knowledge to JavaScript programmers but
asyncandawaitare not general purpose coroutines, that is to say, anasyncfunction does not necessarily suspend execution on eachawaitin the sense of unblocking the main event loop. This is because Promises run on the "microtask queue" and the browser will keep running them until there are no more left before it goes back to doing important things like responding to user input: https://developer.mozilla.org/en-US/docs/Web/API/HTML_DOM_API/Microtask_guide#microtasksObviously if you launch a bunch of async functions or Promises they will yield to each other but that is not actually what you want in most cases.
Concretely this means that using
asyncfor CPU-bound APIs is considered harmful (tm). So we have to removeasyncfrom most functions in the API.Conversely, for IO-bound APIs it is considered useful (tm). So initialization will definitely remain async/promise based.