Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build Python 3.13 wheels too #67

Merged
merged 3 commits into from
Nov 22, 2024
Merged

build: build Python 3.13 wheels too #67

merged 3 commits into from
Nov 22, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Nov 12, 2024

PR Goal?

Create wheels for Python 3.13

Fixes?

Make it easier to install in Windows for Python 3.13

Feedback sought?

Sanity check

Priority?

medium

Tests added?

tested manually, works fine on my machine, will dispatch build_wheel to make sure that works too

How to test?

Run the CI workflow build_wheels.yml

Confidence?

medium, will be high once I'm done testing

Version change?

yes, will need patch bump to publish py313 wheels.

@joanise joanise requested a review from dhdaines November 12, 2024 17:23
@joanise
Copy link
Member Author

joanise commented Nov 12, 2024

@dhdaines I've tested this to my satisfaction now, the workflow builds the wheels for 3.8..3.13 inclusively for the three OSs. I can install the win py3.13 wheel on my Windows machine and get ReadAlong Studio's test suite to pass (with some other changes I'll have to PR for that project to support 3.13 too).

@joanise
Copy link
Member Author

joanise commented Nov 12, 2024

Once this is merged, I would like to release 0.6.5

Copy link
Contributor

@dhdaines dhdaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Sorry it took me weeks to get around to approving such a simple PR!

@dhdaines dhdaines merged commit 3dc4f87 into main Nov 22, 2024
10 checks passed
@dhdaines dhdaines deleted the dev.ej/py313 branch November 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants