-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump black and mypy to most recent with py 3.8 support #71
Conversation
Removed line parser.add_argument_group(grammars) which a) was never meant to be allowed, and b) isn't required anyway, it doesn't actually do anything. See the deprecation note in https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument_group
@cclauss Turned out bumping mypy was not so hard, and black trivial up to 24.8. |
"isort", | ||
"mypy==0.991", | ||
"mypy==1.13.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these tools run OUTSIDE of pre-commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes, yes, though not automatically. I certainly prefer to have them installed in my venv and ready to call from the bash prompt. In all my projects, pip install -e .[dev]
will give me black, isort, mypy, usually flake8 too, with whatever configuration is needed to "just work".
These can be installed with
|
Oh, oops, indeed, it is totally redundant! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Removed line
parser.add_argument_group(grammars)
which a) was never meant to be allowed,
and b) isn't required anyway, it doesn't actually do anything.
See the deprecation note in
https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument_group
PR Goal?
just keeping the repo tidy, in the same spirit as #68 and #70
Feedback sought?
rubber stamping
Priority?
low
Tests added?
n/a
How to test?
Run
pre-commit run --all-files
and see no warnings anymoreRun
soundswallower -h
,soundswallower -a foo -t bar
and see that the mutually exclusive group still works.Confidence?
high
Version change?
no