Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump black and mypy to most recent with py 3.8 support #71

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Dec 12, 2024

Removed line
parser.add_argument_group(grammars)
which a) was never meant to be allowed,
and b) isn't required anyway, it doesn't actually do anything.

See the deprecation note in
https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument_group

PR Goal?

just keeping the repo tidy, in the same spirit as #68 and #70

Feedback sought?

rubber stamping

Priority?

low

Tests added?

n/a

How to test?

Run pre-commit run --all-files and see no warnings anymore

Run soundswallower -h, soundswallower -a foo -t bar and see that the mutually exclusive group still works.

Confidence?

high

Version change?

no

Removed line
    parser.add_argument_group(grammars)
which a) was never meant to be allowed,
and b) isn't required anyway, it doesn't actually do anything.

See the deprecation note in
https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument_group
@joanise joanise requested a review from dhdaines December 12, 2024 18:30
@joanise
Copy link
Member Author

joanise commented Dec 12, 2024

@cclauss Turned out bumping mypy was not so hard, and black trivial up to 24.8.

"isort",
"mypy==0.991",
"mypy==1.13.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these tools run OUTSIDE of pre-commit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes, yes, though not automatically. I certainly prefer to have them installed in my venv and ready to call from the bash prompt. In all my projects, pip install -e .[dev] will give me black, isort, mypy, usually flake8 too, with whatever configuration is needed to "just work".

@cclauss
Copy link
Contributor

cclauss commented Dec 12, 2024

These can be installed with pipx install or uv tool install which is probably better than specifying their version numbers in two locations.

pipx run and uv tool run or uvx also make this easy.

pre-commit run mypy --all-files

@dhdaines
Copy link
Contributor

Removed line parser.add_argument_group(grammars) which a) was never meant to be allowed, and b) isn't required anyway, it doesn't actually do anything.

Oh, oops, indeed, it is totally redundant!

Copy link
Contributor

@dhdaines dhdaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@dhdaines dhdaines merged commit e6accb2 into main Dec 13, 2024
5 checks passed
@dhdaines dhdaines deleted the dev.ej/bump-mypy-black branch December 13, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants