Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical error OnApp reload #9

Closed
ReadieFur opened this issue Jan 28, 2021 · 2 comments
Closed

Critical error OnApp reload #9

ReadieFur opened this issue Jan 28, 2021 · 2 comments

Comments

@ReadieFur
Copy link
Owner

I have had messages say that my mod was causing critical erorrs when the app was reloaded, e.g. a setting in the settings menu was changed. This would cause the ScoreController and GameEnergyController to stop working entirely.
@ReadieFur
Copy link
Owner Author

The websocket server is set to start up when the zenject OnApp is run. On this OnApp event I have an IInitializable and IDisposable websocket class. On dispose I tell the websocketserver to stop but it seems that this kills the game which confuses me but im trying to figure out why.

@ReadieFur
Copy link
Owner Author

I have fixed the issue by moving it outsize of zenject however I am still trying to figure out why this broke so badly. (These messages were snippits from a Discord DM I had).

ReadieFur pushed a commit that referenced this issue Jan 28, 2021
@Readie1593
Fixed a critical error with the OnApp reload (#9)
27a5567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ReadieFur