Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SongDetails retrieval logic #15

Closed
wants to merge 1 commit into from

Conversation

kinsi55
Copy link

@kinsi55 kinsi55 commented Dec 29, 2021

Reuse the same instance after having created one so you dont need to double send data after the first init

Might contain some minor syntax issues, I edited with the GH web editor but logic should be fine

ReadieFur added a commit that referenced this pull request Jan 1, 2022
@ReadieFur ReadieFur closed this Jan 1, 2022
@ReadieFur
Copy link
Owner

Updated in commit 2.0.10...2.0.11

@kinsi55
Copy link
Author

kinsi55 commented Jan 1, 2022

With how you changed the beatSaver.BeatmapByHash(mapHash) call, its on the main thread. This is fine for the SongDetails load because it itself uses a Task.Run() internally but I'm not too sure if BeatmapByHash does that

@ReadieFur
Copy link
Owner

Interesting, though I don't believe this will be a problem as the data it sets and checks is minimal and shouldn't impact much, though I don't know about the function I'm waiting on itself, how that could affect things. From my quick tests it still seemed fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants