Feature: Split PR & issues into separate events #272

A2-NieR · 2023-04-01T11:08:15Z

read and understood the Contributing Guidelines
Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

Minor Change
This Pull request doesn't break existing configuration.
Major Change
This Pull request will break existing configuration.
Bug fix
This Pull request will fix a (critical) bug.
Documentation
This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
Other: __________

Description

This PR splits the pr and issue events into different events so users can better include/exclude specific events.

To Do:

Update changelog after Merge/Release

abhijoshi2k · 2023-04-02T12:16:34Z

For backward compatibility, we shouldn't discard the original pr and issue events.
If the older events are excluded, they should block all sub events.

For example, if pr is excluded, it should block pr_opened, pr_merged and pr_closed events.

A2-NieR · 2023-04-03T09:04:34Z

For backward compatibility, we shouldn't discard the original pr and issue events. If the older events are excluded, they should block all sub events.

For example, if pr is excluded, it should block pr_opened, pr_merged and pr_closed events.

Makes sense. I will look into it.
Btw. how does one test the workflow? Tried with act but always run into this error:

act -s GITHUB_TOKEN=ghp_xyz... -j build -W .github/workflows/test-workflow.yml

docker exec cmd=[node /var/run/act/actions/Readme-Workflows-recent-activity@main/dist/index.js] user= workdir=
| serializers
| {
|   PushEvent: [Function: PushEvent],
|   IssuesEvent: [Function: IssuesEvent],
|   PullRequestEvent: [Function: PullRequestEvent],
|   CreateEvent: [Function: CreateEvent],
|   ForkEvent: [Function: ForkEvent],
|   GollumEvent: [Function: GollumEvent],
|   MemberEvent: [Function: MemberEvent],
|   PullRequestReviewEvent: [Function: PullRequestReviewEvent],
|   ReleaseEvent: [Function: ReleaseEvent],
|   WatchEvent: [Function: WatchEvent]
| }
| ✖  error     Event `push` is not supported by this action.

abhijoshi2k · 2023-04-07T04:01:28Z

You can run the workflow on your own repo to test it.
For example, you can run the workflow by editing your workflow file as: BunnyTheLifeguard/recent-activity@feat/split-pr-events

PuneetGopinath · 2023-04-10T15:55:05Z

src/serializers.js

@@ -10,8 +10,11 @@ const IssueCommentEvent = require("./events/IssueCommentEvent");
 const CommitCommentEvent = require("./events/CommitCommentEvent");
 const PullRequestReviewCommentEvent = require("./events/PullRequestReviewCommentEvent");
 const PushEvent = require("./events/PushEvent");
-const IssuesEvent = require("./events/IssuesEvent");
-const PullRequestEvent = require("./events/PullRequestEvent");
+const IssuesOpenEvent = require("./events/IssuesOpenEvent");


This is where the problem lies. GitHub API does not provide a type of the value "IssuesOpenEvent" or the other new names that you have made. Due to this change, while testing I see that none of the issue and pull request-related events are shown in the profile.
You can checkout https://docs.github.com/en/developers/webhooks-and-events/github-event-types for the docs

You have to modify the functions/filterContent.js file to use the respective serializers for their respective events

Ah I see, thanks for the info.
Rn I don't have the time, so I can close the PR until I can look into this if you want me to?

You don't need to close the pr, let it be open. Whenever free you can look into the issue, that's not an problem.
We appreciate your efforts to contribute to Readme-Workflows!

PuneetGopinath

Please do the needful.

A2-NieR · 2023-04-15T14:06:57Z

Reverted the Events according to the GH API and implemented a filter to extract disabled issues/pr actions.

PuneetGopinath · 2023-04-19T04:42:54Z

Reverted the Events according to the GH API and implemented a filter to extract disabled issues/pr actions.

Sorry, I read the comment and the forgot it totally.
Did you test it? If so can you show the workflow results

I'm really very sorry for being inactive.

PuneetGopinath · 2023-04-24T15:24:54Z

@Andre601 @abhijoshi2k Should we change 2021 to 2023 in the copyright in all code files? Or instead 2021 - 2023?
What's your opinion?

And the code has been tested and works... LGTM @bunnythelifeguard
Thank you for your contribution!

A2-NieR · 2023-04-24T15:27:23Z

@Andre601 @abhijoshi2k Should we change 2021 to 2023 in the copyright in all code files? Or instead 2021 - 2023? What's your opinion?

And the code has been tested and works... LGTM @bunnythelifeguard Thank you for your contribution!

Awesome, thanks.

In my own repo I saw that PR stuff was listed again, but had no time to test for merge, close etc. :/

abhijoshi2k · 2023-04-24T15:31:13Z

@PuneetGopinath I think we can change that to 2023. Feel free to do the change before release.

PuneetGopinath · 2023-05-02T16:05:53Z

@Andre601 Can you do the release? I don't remember anything after a year of not touching github 😄

Andre601 · 2023-05-02T21:24:08Z

@Andre601 Can you do the release? I don't remember anything after a year of not touching github 😄

Me neither. Need to look at this.
What release version should it be?

A2-NieR added 4 commits April 1, 2023 12:47

feat: split pr events

b6969a5

docs: update split pr events

d072371

docs: update readme w/ new pr events

9f16f85

docs: fix vscode auto toc update

5682e1a

A2-NieR requested review from Andre601, abhijoshi2k and PuneetGopinath as code owners April 1, 2023 11:08

feat: split issues into separate open/close events

ff277b5

A2-NieR changed the title ~~Feature: Split PR events into separate open/merge/close events~~ Feature: Split PR & issues into separate events Apr 1, 2023

fix: old serializer eventname

3edf457

PuneetGopinath added Status: In progress This pr or issue is in progress Type: breaking This change will break previous versions labels Apr 10, 2023

PuneetGopinath reviewed Apr 10, 2023

View reviewed changes

PuneetGopinath requested changes Apr 10, 2023

View reviewed changes

A2-NieR force-pushed the feat/split-pr-events branch 4 times, most recently from f423e4f to cdd8e50 Compare April 15, 2023 13:51

fix: refactor gh api event types

c2b5675

A2-NieR force-pushed the feat/split-pr-events branch from cdd8e50 to c2b5675 Compare April 15, 2023 13:54

A2-NieR added 2 commits April 15, 2023 16:00

docs: update readme

6e22861

fix: update eventlist

973fd4d

PuneetGopinath approved these changes Apr 24, 2023

View reviewed changes

Merge branch 'main' into feat/split-pr-events

4886455

PuneetGopinath merged commit fba5248 into Readme-Workflows:main May 2, 2023

PuneetGopinath added a commit to PuneetGopinath/recent-activity that referenced this pull request May 15, 2023

fix: filterContent not working properly after Readme-Workflows#272

6b741ca

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Split PR & issues into separate events #272

Feature: Split PR & issues into separate events #272

A2-NieR commented Apr 1, 2023 •

edited

Loading

abhijoshi2k commented Apr 2, 2023

A2-NieR commented Apr 3, 2023

abhijoshi2k commented Apr 7, 2023

PuneetGopinath Apr 10, 2023

PuneetGopinath Apr 10, 2023

A2-NieR Apr 11, 2023

PuneetGopinath Apr 11, 2023 •

edited

Loading

PuneetGopinath left a comment

A2-NieR commented Apr 15, 2023 •

edited

Loading

PuneetGopinath commented Apr 19, 2023

PuneetGopinath commented Apr 24, 2023

A2-NieR commented Apr 24, 2023

abhijoshi2k commented Apr 24, 2023

PuneetGopinath commented May 2, 2023

Andre601 commented May 2, 2023

Feature: Split PR & issues into separate events #272

Feature: Split PR & issues into separate events #272

Conversation

A2-NieR commented Apr 1, 2023 • edited Loading

Type of Pull request

Description

To Do:

abhijoshi2k commented Apr 2, 2023

A2-NieR commented Apr 3, 2023

abhijoshi2k commented Apr 7, 2023

PuneetGopinath Apr 10, 2023

Choose a reason for hiding this comment

PuneetGopinath Apr 10, 2023

Choose a reason for hiding this comment

A2-NieR Apr 11, 2023

Choose a reason for hiding this comment

PuneetGopinath Apr 11, 2023 • edited Loading

Choose a reason for hiding this comment

PuneetGopinath left a comment

Choose a reason for hiding this comment

A2-NieR commented Apr 15, 2023 • edited Loading

PuneetGopinath commented Apr 19, 2023

PuneetGopinath commented Apr 24, 2023

A2-NieR commented Apr 24, 2023

abhijoshi2k commented Apr 24, 2023

PuneetGopinath commented May 2, 2023

Andre601 commented May 2, 2023

A2-NieR commented Apr 1, 2023 •

edited

Loading

PuneetGopinath Apr 11, 2023 •

edited

Loading

A2-NieR commented Apr 15, 2023 •

edited

Loading