Feat/socket support #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamitprakash
requested changes
Jan 10, 2025
controllers/websocketHandler.go
Outdated
| return | ||
| } | ||
|
|
||
| log.Printf("Connected with %v", session.connection.RemoteAddr()) |
There was a problem hiding this comment.
replaced it with logrus
| @@ -7,6 +7,6 @@ import ( | |||
| ) | |||
|
|
|||
| func main() { | |||
| logrus.Info("Starting server on port " + config.AppConfig.Port) | |||
| routes.Listen(":" + config.AppConfig.Port) | |||
| logrus.Info("Starting server on port " + config.AppConfig.PORT) | |||
There was a problem hiding this comment.
and here logrus why so ..?
There was a problem hiding this comment.
thanks for pointing it out, I've now updated it with logrus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 10 Jan 2025
Developer Name: Joy Gupta
Issue Ticket Number
#28
Description
This PR contains code to enable websocket in discord service which later on can be used to connect with discord queue
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screen.Recording.2025-01-10.at.10.43.25.AM.mov
Test Coverage
Additional Notes