Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Main Sync #297

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Dev to Main Sync #297

wants to merge 3 commits into from

Conversation

Achintya-Chatterjee
Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee commented Jan 14, 2025

Date: 18 Jan, 2024

Developer Name: @pankajjs @vikhyat187


Issue Ticket Number

PR going in this sync

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Working Proof - When an onboarding user makes a request
staging-demo-1.mp4
  • When super-user makes a request for onboarding user.
Screenshot 2025-01-18 at 12 28 47 AM
  • Get all onboarding requests
Screenshot 2025-01-18 at 12 29 30 AM

Test Coverage

Screenshot 1

Additional Notes

vikhyat187 and others added 3 commits December 23, 2024 21:18
- Added command and handler

- Changed required default value

- Added constant message

- Changed field name and argument

- Fixed function argument and types

- Added super user field

- Added validation for super-user and fixed reply

- Changed field, expectation message and test name as it was failing

- Restore all mocks in after-each hook

- Fixed lint issue

- Added assert statement to verify the function call signature and fixed test name

- Added tests to handle edge cases and fixed existing failing tests
…n-command

feat: Add onboarding extension command to create an onboarding extension request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants