Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api contract for Post /requests endpoint of onboarding extension requests #216

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pankajjs
Copy link

@pankajjs pankajjs commented Dec 28, 2024

Date: 28 Dec, 2024

Developer Name: Pankaj Sha


Issue Ticket Number

Description

This PR adds api contract for POST /requests endpoint of onboarding extension requests.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes


- **Error Responses of Onboarding Extension Request:**
- **Code:** 400
- **Content:** `{ "statusCode": 400, "error": "Bad Request", "message": "Request already exists please wait for approval or rejection" }`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use 409 here?

Copy link
Author

@pankajjs pankajjs Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we use 409?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we have decided to go with 400 status code in design doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Post /requests api contract for onboarding extension requests
2 participants