fix: send 404 response when request does not exist

Real-Dev-Squad · Jan 9, 2025 · e548f24 · e548f24
1 parent 10e2497
commit e548f24
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/controllers/onboardingExtension.ts b/controllers/onboardingExtension.ts
@@ -5,6 +5,7 @@ import {
     ONBOARDING_REQUEST_CREATED_SUCCESSFULLY,
     REQUEST_ALREADY_PENDING,
     REQUEST_APPROVED_SUCCESSFULLY,
+    REQUEST_DOES_NOT_EXIST,
     REQUEST_LOG_TYPE,
     REQUEST_REJECTED_SUCCESSFULLY,
     REQUEST_STATE,
@@ -165,6 +166,9 @@ export const updateOnboardingExtensionRequestState = async (
         const response = await updateRequest(extensionId, requestBody, lastModifiedBy, REQUEST_TYPE.ONBOARDING);
 
         if ("error" in response) {
+            if (response.error === REQUEST_DOES_NOT_EXIST) {
+                return res.boom.notFound(response.error);
+            }
             return res.boom.badRequest(response.error);
         }
 

diff --git a/test/integration/onboardingExtension.test.ts b/test/integration/onboardingExtension.test.ts
@@ -420,16 +420,16 @@ describe("/requests Onboarding Extension", () => {
             })
         })
 
-        it("should return 400 response for invalid extension id", (done) => {
+        it("should return 404 response for invalid extension id", (done) => {
             chai.request(app)
             .put(`/requests/1111?dev=true`)
             .set("authorization", `Bearer ${authToken}`)
             .send(body)
             .end((err, res) => {
                 if (err) return done(err);
-                expect(res.statusCode).to.equal(400);
+                expect(res.statusCode).to.equal(404);
                 expect(res.body.message).to.equal("Request does not exist");
-                expect(res.body.error).to.equal("Bad Request");
+                expect(res.body.error).to.equal("Not Found");
                 done();
             })
         })