feat: Add api to approve and reject onboarding extension requests #2324
+332
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajjs
force-pushed
the
feat/add-approval-rejection-api-for-super-users
branch
from
87a1777 to
d17ec3d
Compare
pankajjs
changed the title
pankajjs
force-pushed
the
feat/add-approval-rejection-api-for-super-users
branch
from
ddccab3 to
3d0af41
Compare
…rejection state - Add constant and types for update request state - Add controller to update onboarding status - Add dev query in request and implemented feature flag - Change request body when reason is undefined - Add onboarding type in schema for request body validation - Fix actual message in assert statement - Add tests to validate the controller - Remove destructure body - Fix string type spelling - Add jsDoc for controller to maintain good practise - Add tests to handle more edge case and fix test name - Fix lint issue - Refactor type name for better readability and fix field name - Add message field in request schema, refactor controller and test to handle message field - Refactor function name to define its purpose - Import addLog from service file - Fix jsDoc documentation
pankajjs
force-pushed
the
feat/add-approval-rejection-api-for-super-users
branch
from
3d0af41 to
0fb1160
Compare
pankajjs
force-pushed
the
feat/add-approval-rejection-api-for-super-users
branch
from
6abbb1c to
6e2aa89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 29 Dec, 2024
Developer Name: @pankajjs
Issue Ticket Number
Description
This PR contains test and feature related to approval and rejection of onboarding extension request by super-users.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes