test : add tests for pagination of progresses api #2328
+536
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
pankajjs
reviewed
Dec 30, 2024
pankajjs
reviewed
Dec 30, 2024
pankajjs
reviewed
Dec 30, 2024
VinuB-Dev
reviewed
Jan 3, 2025
VinuB-Dev
reviewed
Jan 3, 2025
VinuB-Dev
reviewed
Jan 3, 2025
VinuB-Dev
reviewed
Jan 7, 2025
Comment on lines
764
to
765
| "The server has encountered an unexpected error. Please contact the administrator for more information.", | ||
| }); |
There was a problem hiding this comment.
Don't we have a default / constant message here? Could you check how other parts of the application handle this?
There was a problem hiding this comment.
No we don't have any constant for this. You can check this test for refrence test
There was a problem hiding this comment.
Thanks for confirming. It's a good practice to have a consistent error message for 500 status codes across the application. Let's have a constant and use that in the future also. It'll help with future maintenance and keep the UX unified.
There was a problem hiding this comment.
Hello @VinuB-Dev I am using constant value now can you please check. Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 30 Dec 2024
Developer Name: @AnujChhikara
Issue Ticket Number
Description
Addes tests for the pagination of the progresses API
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
Added tests for PR - #2325