Dev to Main Sync #2336
Open
Dev to Main Sync #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver (#2307) * fix:added onboarding type in request * feat: added types for onboarding extension request * feat: added validator and skip-authenticate middleware * fix: added missing field in user type * feat: added controller for handling the create onboarding extension request feature * fix: remove requestedBy field because validation for super-users is done before hitting this api * refactor: moved constant messages from controller * fix: remove super-users validation check as it is done before making this api call * fix: create newEndsOn from current date when deadline has missed * fix: wrap schema validation logic in try-catch block * chore: refactor varibale name for better readability * chore: refactor new deadline calculation logic in a separate utils file for reuse * chore: use utils function to calculate days to milliseconds * feat: added utils function to validate date * fix: return error response for invalid date * fix: return forbidden response for non-onboarding user * chore: added semicolon for consistent code practise * chore: added jsDoc for functions and refactor import statment * fix: import addLog from service file and fix lint issue
* feat: added tests for middlewares * feat:added tests for controller * refactor: create middleware in beforeEach hook * refactor: remove requestBy field and super-users validation tests * fix: expectation message as test was failing * fix: change order of middleware creation as test was failing * fix: assert statement and mock value * feat: added tests for handling edges cases and fixed existing test * chore: correct test name * chore: fix lint issue
#2311) * initial * fix typos * using batches to fetch userIds * refactor the function * added test for dev false case * added unit tests * fix response body containing email --------- Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
Developer Name:
Issue Ticket Number
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes