Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send conflict response when user has a pending request #2339

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: send conflict response when user has a pending request #2339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/onboardingExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const createOnboardingExtensionRequestController = async (req: Onboarding
});

if(latestExtensionRequest && latestExtensionRequest.state === REQUEST_STATE.PENDING){
return res.boom.badRequest(REQUEST_ALREADY_PENDING);
return res.boom.conflict(REQUEST_ALREADY_PENDING);
}

const millisecondsInThirtyOneDays = convertDaysToMilliseconds(31);
Expand Down
6 changes: 3 additions & 3 deletions test/integration/onboardingExtension.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ describe("/requests Onboarding Extension", () => {
})
})

it("should return 400 response when a user already has a pending request", (done)=> {
it("should return 409 response when a user already has a pending request", (done)=> {
createUserStatusWithState(testUserId, userStatusModel, userState.ONBOARDING);
requestsQuery.createRequest({...extensionRequest, state: REQUEST_STATE.PENDING, userId: testUserId});

Expand All @@ -225,8 +225,8 @@ describe("/requests Onboarding Extension", () => {
.send(body)
.end((err, res) => {
if (err) return done(err);
expect(res.statusCode).to.equal(400);
expect(res.body.error).to.equal("Bad Request");
expect(res.statusCode).to.equal(409);
expect(res.body.error).to.equal("Conflict");
expect(res.body.message).to.equal(REQUEST_ALREADY_PENDING);
done();
})
Expand Down
Loading