Fixed: Added a button to close model. #1312
Conversation
|
@ZendeAditya is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
|
|
The build is failing, please fix that. |
Why is development tested no here? |
|
Hey @tejaskh3 @AnujChhikara Please check it now i fix the node version back to 18 |
where? can you please check if you have pushed latest changes. |
|
ZendeAditya
force-pushed
the
fix/model-form
branch
from
60b7ec3 to
6cb306c
Compare
|
as the implementation is changed, can you please update the video or screenshot? |
Yes I will update it |
|
@tejaskh3 updated image and video with a new one |
|
Hello @ZendeAditya can you please write test for you changes and attach test coverage in the description |
Yes |
|
|
@tejaskh3 @AnujChhikara |
please check this |
|
Please make your changes behind feature flag. |
|
@ZendeAditya This comment #1312 (comment) is not yet resolved |
ZendeAditya
force-pushed
the
fix/model-form
branch
from
3d3a353 to
4202e60
Compare
|
Code looks good. |
|
Hey @tejaskh3 @AnujChhikara what Is the next process for merging PR. |
you can tag Tejas sir and asked him to merge this PR and mention you got 3 approvals |
* Add modal to acknowledge user about status change on marking progress to 100% (#1322) * initial commit * refactor code * added feature flag * refactored some code * changed casing and removed comments * changed to predefined colouring * removed unnecessary useCallbacks * removed onstatus function * resolved commented changes * decereased the mismatch between the modal and design doc modal * changed button color * font change * used the already created modal component * dimensional changes * refactored function * small refactoring * async await updated * applied callback on close icon * refactored to named exports * removed a div element * rounded off the rem values * put the close icon inside button wrapper * rounded off rems * rounded off rem values * Fixed: Added a button to close model. (#1312) * Close button added * Added cross button on update modal * Formatting done * All Test Passed * Unnecessery Code Removed * Fix test to check if setIsOpen is called on close button click * Tests / Add modal to acknowledge user about status change on marking progress to 100% (#1324) * initial changes * removed unnecessary lines * removed the onStatusChange tests * added one more check to ensure that the onclose() function is working * added more tests * added should before each line * added braces * added dev flag tests * added the testid check * added skip to tests * added skeleton components to pass linitng checks * added one more test case * removed skips * added a getAllByRole --------- Co-authored-by: Rishi Chaubey <155433512+RishiChaubey31@users.noreply.github.com> Co-authored-by: Aditya Zende <adityazende6710@gmail.com>
Date: 13/01/2025
Developer Name: Aditya Zende (aditya-zende-1)
Issue Ticket Number
Description
Added a cross button on Task Update Modal.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
loom-video.2.mp4
Test Coverage
Screenshot 1
Additional Notes