-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include some additional room types from Brick #242
Comments
We would also love to be more precies regarding models of rooms in our DigitalTwin. |
Hi, Great list, thanks! We certainly want to align with what exists in Brick already, to ensure a minimum of breakage. I've pulled out the unmatched room types from the table above and have commented on them individually below. Some are obvious additions to REC, for others I think a bit more clarity would be helpful, to ensure that we do not duplicate room types that we might already have -- and that we place new rooms in their proper place in the room taxonomy. Note that the REC Technical Committee is on a summer break and that the next scheduled call (at which PRs are cleared for merger) will be on September 7. Nonetheless, am pinging TC memberships to add visibility and possibly additional comments: @PeteHart @cbupp @erikoskarwallin Best, Karl
|
Easy ones first:
That leaves Cubicle, Equipment_Room, and Team_Room, which I'll take up in a different comment(s). (Pinging @gtfierro too just to keep him in the loop - I don't know Sarah's github ID) |
On cubicle, I think we could live with it being a zone and not a room - the most important thing really is that it's some kind of a space and we can talk about its adjacency/connectivity and containment, so I wouldn't want to just call it a piece of furniture. I'd be careful about making too many assumptions about enclosed-ness for rooms - I think the fire folks are going to have the most stringent requirements on what is a room and what isn't. I'm hoping we can get some of those folks involved here soon - let's talk about it the next time we chat. |
Equipment_room is an oddball in Brick - we have it subclassed from TelecommRoom, to set it apart from distribution rooms like IDFs/MDFs (e.g. https://en.wikipedia.org/wiki/Intermediate_distribution_frame - I think we do want to break out this sort of hierarch), but there's also switch room and TETRA rooms (TETRA is a two-way radio thing.) Maybe we wait on adding equipment_room for a little bit until we have a better sense of how it's used. |
Team_Rooms are close to conference room, though I would picture them different. (Conference rooms are maybe booked for temporary stretches, team rooms are assigned more permanently - they're not quite offices or even open offices, nor are they classrooms or lab spaces, but they're kind of like that) we We'll talk a little bit more in Brick to see if we really need it or if we can find some kind of better "assignable space" designation type we can use, or if we just say "make a team room a room" |
Finally I should track down a few more references, but we've been trying to be better about aligning to other sources for some of our classifications - one we used for Brick was actually from the Federal US Dept of Education - a guide that gets used for reporting space usage in universities, the "Postsecondary Education Facilities Inventory and Classification Manual (FICM)": https://kb.wisc.edu/images/group198/94467/FICM2006Edition.pdf We weren't going to make classes for everything that's listed in FICM (or Omniclass/Uniclass/etc) so we just hit the highlights. |
I agree that we should differentiate a Team Room and a Conference Room based on Erik's definition above. I can ask how people are using Equipment room vs. Mechanical/Utility room. Thanks! |
|
I think Lobby and Reception are distinct and should be different classes, and a team room is distinct from a conference room and should also be a separate class. We can live with Equipment_Room and Mechanical_Room being UtilitesRoom for now, I think. We probably don't need to do anything special for Janitor_Room for now. |
A bit back Sarah Macdougall went through and looked at some of the Brick rooms that they're using that aren't in REC - see this post: https://groups.google.com/g/brickschema/c/CvvoI4n9uSk
There are others missing but these are some that we'd love to see - can we hash out some ideas of either adding these or suggested alternatives?
The text was updated successfully, but these errors were encountered: