Code423n4 #87, correct maxSumOfPrices calculation

RealityCards · Jun 21, 2021 · 10dfc77 · 10dfc77
1 parent a43e7f1
commit 10dfc77
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/contracts/RCMarket.sol b/contracts/RCMarket.sol
@@ -665,7 +665,12 @@ contract RCMarket is Initializable, NativeMetaTransaction, IRCMarket {
         // check that not being front run
         uint256 _actualSumOfPrices;
         for (uint256 i = 0; i < numberOfCards; i++) {
-            _actualSumOfPrices = _actualSumOfPrices + (cardPrice[i]);
+            if (cardPrice[i] == 0){
+                _actualSumOfPrices += MIN_RENTAL_VALUE;
+            } else {
+                _actualSumOfPrices += (cardPrice[i] *
+                            (minimumPriceIncreasePercent + 100)) / 100;
+            }         
         }
         require(_actualSumOfPrices <= _maxSumOfPrices, "Prices too high");