Code423n4 #83, incorrect assert statements

RealityCards · Jun 21, 2021 · 4224160 · 4224160
1 parent 7571199
commit 4224160
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/contracts/RCMarket.sol b/contracts/RCMarket.sol
@@ -359,7 +359,7 @@ contract RCMarket is Initializable, NativeMetaTransaction, IRCMarket {
         );
         uint256 _tokenId = _cardId + totalNftMintCount;
 
-        assert(nfthub.transferNft(_from, _to, _tokenId));
+        nfthub.transferNft(_from, _to, _tokenId);
         emit LogNewOwner(_cardId, _to);
     }
 
@@ -567,7 +567,7 @@ contract RCMarket is Initializable, NativeMetaTransaction, IRCMarket {
 
     /// @notice all payouts happen through here
     function _payout(address _recipient, uint256 _amount) internal {
-        assert(treasury.payout(_recipient, _amount));
+        treasury.payout(_recipient, _amount);
     }
 
     /// @dev the below functions pay stakeholders (artist, creator, affiliate, card specific affiliates)
@@ -754,7 +754,7 @@ contract RCMarket is Initializable, NativeMetaTransaction, IRCMarket {
                     _startingPosition
                 );
 
-                assert(treasury.updateLastRentalTime(_user));
+                treasury.updateLastRentalTime(_user);
             }
         }
     }

diff --git a/contracts/RCTreasury.sol b/contracts/RCTreasury.sol
@@ -450,7 +450,6 @@ contract RCTreasury is Ownable, NativeMetaTransaction, IRCTreasury {
         returns (bool)
     {
         require(!globalPause, "Payouts are disabled");
-        assert(marketPot[msgSender()] >= _amount);
         user[_user].deposit += SafeCast.toUint128(_amount);
         marketPot[msgSender()] -= _amount;
         totalMarketPots -= _amount;