Code423n4 #34, transfer and safeTransfer similar

RealityCards · Jun 16, 2021 · 5dc5957 · 5dc5957
1 parent 746b778
commit 5dc5957
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/contracts/nfthubs/RCNftHubL2.sol b/contracts/nfthubs/RCNftHubL2.sol
@@ -213,10 +213,7 @@ contract RCNftHubL2 is
         address to,
         uint256 tokenId
     ) public override {
-        IRCMarket market = IRCMarket(marketTracker[tokenId]);
-        require(market.state() == IRCMarket.States.WITHDRAW, "Incorrect state");
-        require(ownerOf(tokenId) == msgSender(), "Not owner");
-        _transfer(from, to, tokenId);
+        executeTransfer(from, to, tokenId);
     }
 
     function safeTransferFrom(
@@ -225,11 +222,19 @@ contract RCNftHubL2 is
         uint256 tokenId,
         bytes memory _data
     ) public override {
+        executeTransfer(from, to, tokenId);
+        _data;
+    }
+
+    function executeTransfer(
+        address from,
+        address to,
+        uint256 tokenId
+    ) internal {
         IRCMarket market = IRCMarket(marketTracker[tokenId]);
         require(market.state() == IRCMarket.States.WITHDRAW, "Incorrect state");
         require(ownerOf(tokenId) == msgSender(), "Not owner");
         _transfer(from, to, tokenId);
-        _data;
     }
     /*
          ▲