Code423n4 #53, Unused return value

RealityCards · Jun 16, 2021 · aaa4bbb · aaa4bbb
1 parent fde27f2
commit aaa4bbb
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/contracts/RCOrderbook.sol b/contracts/RCOrderbook.sol
@@ -533,8 +533,8 @@ contract RCOrderbook is Ownable, NativeMetaTransaction, IRCOrderbook {
         external
         override
         onlyMarkets
-        returns (address _newOwner)
     {
+        address _newOwner = address(0);
         address _market = msgSender();
         // the market is the head of the list, the next bid is therefore the owner
         Bid storage _head = user[_market][index[_market][_market][_card]];

diff --git a/contracts/RCTreasury.sol b/contracts/RCTreasury.sol
@@ -425,7 +425,6 @@ contract RCTreasury is Ownable, NativeMetaTransaction, IRCTreasury {
         override
         balancedBooks
         onlyMarkets
-        returns (bool)
     {
         require(!globalPause, "Rentals are disabled");
         if (marketBalance < _amount) {
@@ -436,8 +435,6 @@ contract RCTreasury is Ownable, NativeMetaTransaction, IRCTreasury {
         marketBalance -= _amount;
         marketPot[_market] += _amount;
         totalMarketPots += _amount;
-
-        return true;
     }
 
     /// @notice a payout is equivalent to moving from market pot to user's deposit (the opposite of payRent)

diff --git a/contracts/interfaces/IRCOrderbook.sol b/contracts/interfaces/IRCOrderbook.sol
@@ -31,8 +31,7 @@ interface IRCOrderbook {
     function closeMarket() external;
 
     function findNewOwner(uint256 _token, uint256 _timeOwnershipChanged)
-        external
-        returns (address _newOwner);
+        external;
 
     function getBidValue(address _user, uint256 _token)
         external

diff --git a/contracts/interfaces/IRCTreasury.sol b/contracts/interfaces/IRCTreasury.sol
@@ -64,7 +64,7 @@ interface IRCTreasury {
 
     function withdrawDeposit(uint256 _amount, bool _localWithdrawal) external;
 
-    function payRent(uint256) external returns (bool);
+    function payRent(uint256) external;
 
     function payout(address, uint256) external returns (bool);