Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow limiting what input types can be given to a merge function #305

Closed
RebeccaStevens opened this issue Mar 18, 2023 · 1 comment · Fixed by #448
Closed

Allow limiting what input types can be given to a merge function #305

RebeccaStevens opened this issue Mar 18, 2023 · 1 comment · Fixed by #448
Labels
Resolution: Added This has been added to the project. Status: Released It's now live. Type: Enhancement Enhancement of the code, not introducing new features.

Comments

@RebeccaStevens
Copy link
Owner

Suggestion

<Ts extends ReadonlyArray<unknown>>(...objects: Ts) => DeepMergeHKT<Ts, GetDeepMergeMergeFunctionsURIs<PMF>, DeepMergeBuiltInMetaData>
//                        ^^^^^^^ Allow change this from unknown to a more restrictive type.
@RebeccaStevens RebeccaStevens added the Type: Enhancement Enhancement of the code, not introducing new features. label Mar 18, 2023
@RebeccaStevens RebeccaStevens mentioned this issue Mar 20, 2023
Closed
RebeccaStevens added a commit that referenced this issue May 10, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
6e2a230 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
@RebeccaStevens RebeccaStevens mentioned this issue May 10, 2024
Merged
RebeccaStevens added a commit that referenced this issue May 10, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
f4ecd45 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 10, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
f54235e 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 10, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
67a0cec 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 19, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
d1c3711 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 19, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
4eeed95 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 19, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
0df1138 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 19, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
cebcdec 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 19, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
92f2e12 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 19, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
91bfc4f 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 19, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
db55c56 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
RebeccaStevens added a commit that referenced this issue May 19, 2024
@RebeccaStevens
feat: allow restricting what types can be passed in as parameters
69e9ba3 
BREAKING CHANGE: The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.

fix #305
@github-actions github-actions bot added the Resolution: Added This has been added to the project. label May 19, 2024
github-actions bot pushed a commit that referenced this issue May 19, 2024
@semantic-release-bot
chore(release): 6.0.0 [skip ci]
b610ee0 
# [6.0.0](v5.1.0...v6.0.0) (2024-05-19)

### Bug Fixes

* type when merging optional properties of a record ([fa9ace2](fa9ace2))

### Build System

* remove typing support for typescript<4.7 ([f2f5956](f2f5956))

### Features

* allow restricting what types can be passed in as parameters ([69e9ba3](69e9ba3)), closes [#305](#305)
* remove deprecated type DeepMergeLeafHKT ([1982e56](1982e56))
* undefined will no longer replace defined values by default ([9c86605](9c86605))

### Performance Improvements

* remove BlacklistedRecordProps ([19d4944](19d4944))

### BREAKING CHANGES

* remove deprecated type DeepMergeLeafHKT
* undefined will no longer replace defined values by default
* The order of the generics of `deepmergeCustom`
and `deepmergeIntoCustom` have changed. If you are passing generics
to these functions you need to update them.
* remove typing support for typescript<4.7
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Added This has been added to the project. Status: Released It's now live. Type: Enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
No milestone
1 participant
@RebeccaStevens