Refactor List operator[] to prevent compiler warnings (#94)

RebelToolbox · Aug 24, 2024 · f5a7ec3 · f5a7ec3
2 parents a7041f3 + a773eb8
commit f5a7ec3
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/core/list.h b/core/list.h
@@ -438,31 +438,23 @@ class List {
 
  Element* I = front();
  int c = 0;
- while (I) {
- if (c == p_index) {
- return I->get();
- }
+ while (c < p_index) {
  I = I->next();
  c++;
  }
-
- CRASH_NOW(); // bug!!
+ return I->get();
  }
 
  const T& operator[](int p_index) const {
  CRASH_BAD_INDEX(p_index, size());
 
  const Element* I = front();
  int c = 0;
- while (I) {
- if (c == p_index) {
- return I->get();
- }
+ while (c < p_index) {
  I = I->next();
  c++;
  }
-
- CRASH_NOW(); // bug!!
+ return I->get();
  }
 
  void move_to_back(Element* p_I) {