[String] Cast to INT64 should use base-10 parsing #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohaibbq
requested review from
a team,
ageiduschek,
colincadams,
elchao96,
glorialiu,
ethan-oro and
recidinick
colincadams
approved these changes
Feb 2, 2024
internal/value.go
Outdated
| return strconv.ParseInt(string(sv), 0, 64) | ||
| toParse := string(sv) | ||
| base := 0 | ||
| if !strings.Contains(strings.ToLower(toParse), "0x") { |
There was a problem hiding this comment.
should this be starts with? I also might be tempted to invert this if so that base 10 is the default and we set 0 inside of the condition
There was a problem hiding this comment.
-0x00 and +0x00 are valid, so I'm using contains, if its malformed ParseInt will raise an error for the user
ageiduschek
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using base 0 leads to incorrectly parsed integers as well as errors depending on leading-zero format.
goccy#158