[Window] Support LOGICAL_OR and LOGICAL_AND
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohaibbq
requested review from
a team,
ageiduschek,
colincadams,
ethan-oro and
recidinick
ageiduschek
requested changes
Apr 3, 2024
internal/function_window.go
Outdated
| } | ||
| } | ||
|
|
||
| return BoolValue(true), nil |
There was a problem hiding this comment.
Should this not be BoolValue(false)? Like if there are no trues we return False?
Might make sense to include a test case like this:
SELECT LOGICAL_OR(a) OVER (ORDER BY b), a, b
FROM (
SELECT CAST(a AS BOOL) AS a, b FROM UNNEST([
STRUCT(False AS a, 1 AS b),
STRUCT(False AS a, 2 AS b),
STRUCT(True AS a, 3 AS b),
STRUCT(False AS a, 4 AS b)
])
);
and also one that tests what happens when there are no rows:
SELECT LOGICAL_OR(a) OVER (ORDER BY a)
FROM (
SELECT CAST(a AS BOOL) AS a FROM UNNEST([]) a
);
recidinick
approved these changes
Apr 3, 2024
ageiduschek
approved these changes
Apr 5, 2024
ohaibbq
added a commit
that referenced
this pull request
Jun 29, 2024
* [Window] Support `LOGICAL_OR` and `LOGICAL_AND` * lint * fix LOGICAL_OR default value; add test for no rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.