Support CONTAINS_SUBSTR function
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohaibbq
requested review from
a team,
ageiduschek,
colincadams,
ethan-oro,
emilyemilyemilyemilyemilyemily and
recidinick
ageiduschek
approved these changes
Apr 11, 2024
Comment on lines
+3352
to
+3358
| WITH Recipes AS ( | ||
| SELECT 'Blueberry pancakes' as Breakfast, 'Egg salad sandwich' as Lunch, 'Potato dumplings' as Dinner UNION ALL | ||
| SELECT 'Potato pancakes', 'Toasted cheese sandwich', 'Beef stroganoff' UNION ALL | ||
| SELECT 'Ham scramble', 'Steak avocado salad', 'Tomato pasta' UNION ALL | ||
| SELECT 'Avocado toast', 'Tomato soup', 'Blueberry salmon' UNION ALL | ||
| SELECT 'Corned beef hash', 'Lentil potato soup', 'Glazed ham' | ||
| ) SELECT * FROM Recipes WHERE CONTAINS_SUBSTR(Recipes, 'toast')`, |
ohaibbq
added a commit
that referenced
this pull request
Jun 29, 2024
* Support `CONTAINS_SUBSTR` function * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zetasqllibrary is missing this function spec, so we needed to register it with the catalog ourselves.goccy/go-zetasql#34