Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Publisher] Admin Panel: Update copy for the copy-superagency-metric-settings checkbox and warning message to add more specificity #1185

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Feb 6, 2024

Description of the change

Update copy for the copy-superagency-metric-settings checkbox and warning message to add more specificity that the copying process will overwrite existing child agency settings and that it will copy across all sectors.

Screenshot 2024-02-06 at 11 25 22 AM (@morden35 - I also updated the styling for the warning message to make it pop out more - lmk what you think!)

Related issues

Closes #1178

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

Copy link
Contributor

@morden35 morden35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it! thank you Mahmoud!

@mxosman mxosman merged commit 6f99538 into main Feb 6, 2024
8 checks passed
@mxosman mxosman deleted the mahmoud/ap-warning-copy branch February 6, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants