include FY/CY details for annual reports #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichelle-hall
force-pushed
the
nichelle-hall/update-report-names
branch
3 times, most recently
from
05029d9 to
ae843cc
Compare
nichelle-hall
requested review from
mxosman,
terryttsai,
lilidworkin and
morden35
mxosman
reviewed
Nov 15, 2022
publisher/src/utils/dateUtils.ts
Outdated
| @@ -44,21 +44,41 @@ export const printDateAsMonthYear = (month: number, year: number): string => { | |||
| }; | |||
|
|
|||
| /** | |||
| * @returns either "Annual Report [YEAR]" or "[MONTH] [YEAR]" as a string depending on frequency | |||
| * @example "Annual Report 2022" or "March 2022" | |||
| * @returns either "Annual Report CY[YEAR]", "Annual Report FY[YEAR]-[YEAR+2]" or "[MONTH] [YEAR]" | |||
There was a problem hiding this comment.
nit: I would add a simple note about CY being Calendar Year and FY being Fiscal Year.
nit: [YEAR+2] should this be [YEAR+1] (I think so, right?)
mxosman
approved these changes
Nov 15, 2022
nichelle-hall
force-pushed
the
nichelle-hall/update-report-names
branch
from
ae843cc to
83d7147
Compare
lilidworkin
reviewed
Nov 16, 2022
There was a problem hiding this comment.
This looks awesome @nichelle-hall ! Thanks for tackling this frontend change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds details about if the annual report represents a calendar or fiscal year in the reports overview page.
Related issues
Related to #16219
Checklists
Development
This box MUST be checked by the submitter prior to merging:
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: