[Publisher][Agency Settings] Fix data source questions bugs #1600
Conversation
| if (key !== "CURRENT_AGENCY") { | ||
| updatedSetting[sourceType].collection_method.value = ""; | ||
| if (key !== "OTHER") { | ||
| updatedSetting[sourceType].collection_method.other_description = ""; | ||
| } | ||
| } | ||
| if (key !== "OTHER_AGENCY_OR_SYSTEM") { | ||
| updatedSetting[sourceType].modification.value = ""; | ||
| if (key !== "OTHER") { | ||
| updatedSetting[sourceType].modification.other_description = ""; | ||
| } | ||
| } | ||
| if (key !== "OTHER") { | ||
| updatedSetting[sourceType][settingType].other_description = ""; | ||
| } |
There was a problem hiding this comment.
Can you help me understand this section here? I'm confused - I assumed it's wiping out the other fields, but am not totally sure.
So if I select the second choice in What is the source of biological sex data in your system?:
What is the source of biological sex data in your system?
[x] Data is collected directly by the agency
This will clear out the collection_method value?
There was a problem hiding this comment.
Ah, I'm following now - would you mind adding a small comment here explaining what these conditionals are doing for posterity?
There was a problem hiding this comment.
Welcome back @mxosman!
I moved all the issues you mentioned here into a separate task, if that's ok!
I also fix this part anyway:
Empty out the fields and send the empty field to the BE when a user clicks away from the "Other"
That's perfect - I appreciate you making a separate task!
Looks great - just a request to add comments in the conditionals clearing out the non-relevant fields! Thank you for knocking these out so quickly - and for fixing the emptying out the fields when clicking away from "Other"!
Description of the change
Fixed issues and bugs of data source questions
Type of change
Related issues
closes #1599
Checklists
Development
This box MUST be checked by the submitter prior to merging:
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: