Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race & Ethnicities (Playtesting Followup): Group Races by Ethnicities in Data Entry Publish Confirmation #179

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Nov 23, 2022

Description of the change

Cleans up the Data Entry Publish Confirmation rendering of the Race & Ethnicities dimensions by grouping the dimensions by ethnicity w/ respective headers.

The disaggregation headers are already an incredibly small font size and I couldn't reasonably go smaller for the ethnicity headers - so I opted to keep them the same size but with a grey font color. Not sure if it's clear or confusing - would love some design help or your ideas if unclear.

Demo:

Screen.Recording.2022-11-23.at.2.22.08.PM.mov

Related issues

Contributes to #180

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman marked this pull request as ready for review November 28, 2022 17:07
@mxosman mxosman requested a review from a team November 28, 2022 17:08
@terryttsai
Copy link
Contributor

Good question on the design of this, I wonder if it's worth rendering a grid for this (though that might not be any less confusing)

@lilidworkin
Copy link
Collaborator

lilidworkin commented Nov 28, 2022

I think this is a pretty good solution @mxosman ! If you want you can run it by @hobuobi , but this seems fine for now. Agreed with @terryttsai that a grid might make most sense eventually, but doesn't seem highest priority to me.

@mxosman
Copy link
Contributor Author

mxosman commented Nov 29, 2022

Sounds good - thank you both for the feedback. I'll leave as is for now and am happy to update it whenever we decide to style it differently.

@mxosman mxosman merged commit ddeba9c into main Nov 29, 2022
@mxosman mxosman deleted the mahmoud/re-de-review branch November 29, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants