Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Data Upload: Error/Warning Page #19

Merged
merged 20 commits into from
Sep 17, 2022
Merged

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Sep 14, 2022

Description of the change

Fleshes out the Error/Warning page. There are a two main types of errors that can occur after an upload:

  1. Pre-ingest errors (errors that occur when the file cannot be properly parsed)
  2. Metric errors and/or warnings that occur within the sheets of the Excel file

If an upload has only warnings (and no errors), the user will have a Continue button that will enable them to continue to the confirmation page.

Uploading a file that only has warnings (lorem ipsum for now - would love copy ideas):

WarningsOnly.mov

Uploading a file that has metric errors & a file that generates pre-ingest errors:

Metric.Errors.and.PreIngest.Errors.mov

Related issues

Closes #18

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman changed the title [WIP][Frontend] Data Upload: Error/Warning Page [Frontend] Data Upload: Error/Warning Page Sep 15, 2022
@mxosman
Copy link
Contributor Author

mxosman commented Sep 15, 2022

Right now, I'm doing an either/or with the metric errors and the pre-ingest errors, where the pre-ingest errors take precedence over the metric errors with regards to being displayed. So, if there are both metric errors and pre-ingest errors, the error page will only display the pre-ingest errors (not sure if we'll ever reach a state where both pre-ingest and metric errors are displayed). Please let me know if I should handle this differently.

@mxosman mxosman marked this pull request as ready for review September 15, 2022 21:38
@mxosman mxosman requested a review from a team September 15, 2022 21:39
Copy link
Collaborator

@lilidworkin lilidworkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome!!

@mxosman mxosman force-pushed the mahmoud/bu-error-warning branch from 969a01b to 17eff2d Compare September 16, 2022 21:47
@mxosman mxosman requested a review from lilidworkin September 16, 2022 21:55
@mxosman mxosman merged commit bb46659 into main Sep 17, 2022
@mxosman mxosman deleted the mahmoud/bu-error-warning branch September 17, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Data Upload: Error/Warning Page
3 participants