-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Data Upload: Error/Warning Page #19
Conversation
Right now, I'm doing an either/or with the metric errors and the pre-ingest errors, where the pre-ingest errors take precedence over the metric errors with regards to being displayed. So, if there are both metric errors and pre-ingest errors, the error page will only display the pre-ingest errors (not sure if we'll ever reach a state where both pre-ingest and metric errors are displayed). Please let me know if I should handle this differently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking awesome!!
969a01b
to
17eff2d
Compare
Description of the change
Fleshes out the Error/Warning page. There are a two main types of errors that can occur after an upload:
If an upload has only warnings (and no errors), the user will have a
Continue
button that will enable them to continue to the confirmation page.Uploading a file that only has warnings (lorem ipsum for now - would love copy ideas):
WarningsOnly.mov
Uploading a file that has metric errors & a file that generates pre-ingest errors:
Metric.Errors.and.PreIngest.Errors.mov
Related issues
Closes #18
Checklists
Development
This box MUST be checked by the submitter prior to merging:
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: