Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Pull Request Labels on all PRs #20

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Require Pull Request Labels on all PRs #20

merged 1 commit into from
Sep 15, 2022

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Sep 14, 2022

Description of the change

Adds pull request label requirement to our CI workflows.

Related issues

Closes #9

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman requested a review from a team September 14, 2022 23:48
Copy link
Collaborator

@lilidworkin lilidworkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

Copy link
Contributor

@terryttsai terryttsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, are we in general following the same policies put in place by Peter in the old repo?

@lilidworkin
Copy link
Collaborator

@terryttsai yes exactly that's the idea!

@mxosman mxosman merged commit cbb1ec8 into main Sep 15, 2022
@mxosman mxosman deleted the mahmoud/ci-labels branch September 15, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require all PRs to have labels like we do in recidiviz-data (e.g. Type: Bug, Type: Feature, etc)
3 participants