-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @recidiviz/design-system from 2.7.0 to 4.1.0 #86
Bump @recidiviz/design-system from 2.7.0 to 4.1.0 #86
Conversation
763ca1a
to
b892e6e
Compare
@dependabot rebase |
@terryttsai what do you think of this one? That seems like a big jump in the design system, do you foresee any problems with that? |
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
Hey @macfarlandian, is there any concern with bumping the design system from 2.7.0 to 4.1.0? Any breaking changes here? |
definitely some breaking changes but mostly isolated to specific features you may or may not be using. I would start by checking the changelog for anything that looks relevant but just give it a shot |
I checked out the branch and clicked through the app, I don't see any breaking changes, so probably good to merge this in and adjust if we catch any issues? |
Sounds good @terryttsai ! For some reason dependabot isn't able to rebase it automatically, would you be able to check it out and do the rebase yourself? |
This PR also looks good to me, what rebase needs to be done? |
yea fair -- was just thinking that it's a month old, so I think it's probably best practice to rebase it onto main first to be safe, but maybe not critical! |
Bumps @recidiviz/design-system from 2.7.0 to 4.1.0. --- updated-dependencies: - dependency-name: "@recidiviz/design-system" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
b892e6e
to
78af3fb
Compare
Bumps @recidiviz/design-system from 2.7.0 to 4.1.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)