Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct id and code return for Stream #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zepouet
Copy link

@zepouet zepouet commented Jun 28, 2020

Hello,

It seems API has changed. Not a problem. Easy to correct.

Second point for start action, your controler returns a 201 for start action.
It seems strange because it is not a real resource creation except if ...

It true so we need to correct other methods.

Thanks a lot for your work !

The value is different

```
ok: [localhost] => {
    "msg": {
        "changed": false,
        "failed": false,
        "json": {
            "stream_id": "5ef8c3019ffb5b2f06323078"
        },
        "msg": "OK (40 bytes)",
        "status": 201,
        "url": "https://graylog.moet-hennessy.net/api/streams"
    }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant