Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake-Batch downloads production compiler during local testing #303

Open
CampGareth opened this issue Nov 13, 2018 · 0 comments
Open

Fake-Batch downloads production compiler during local testing #303

CampGareth opened this issue Nov 13, 2018 · 0 comments

Comments

@CampGareth
Copy link
Contributor

Right now fake-batch is wired up so that in testing it attempts to pull in our production reco-sdaccel container image. Setting aside matters like whether that image is going to be used going forward, it's not a very good resource for testing against. It relies on vivado which is not on developer machines and if it were to run end to end it would take hours.

This might be a good time to revive this PR: #266
We can have the image be automagically made and run basic scripts as a fake workflow that generates logs, sends reports, etc. Meanwhile fake-batch can be made to pull this image by default if it's in a test environment.

@CampGareth CampGareth changed the title Fake-Batch: ContainerCreate: PullImage: Error response from daemon: Get https://398048034572.dkr.ecr.us-east-1.amazonaws.com/v2/reconfigureio/build-framework/sdaccel-builder/manifests/v0.17.5: no basic auth credentials Fake-Batch tries to download production compiler during local testing Nov 13, 2018
@CampGareth CampGareth changed the title Fake-Batch tries to download production compiler during local testing Fake-Batch downloads production compiler during local testing Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant