-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic fake implementation of sdaccel-builder for testing #266
add basic fake implementation of sdaccel-builder for testing #266
Conversation
We have a huge number of top level directories - can it live under one of |
It can indeed, making the change |
Another couple of issues:
I suggest inlining this PR into the PR which starts using it, and fixing the latter issue by having something during the tests which builds the image (with a test image name) and something in the test which causes it to pick up this test image whilst running in development (as opposed to prod). |
688c0c8
to
eb2bf87
Compare
I don't think there's a clear need for this for now. I'll re-open it if one appears in future. |
Re-opening this in the wake of #303 I think if this ends up as an image being created by docker-compose up and then gets tagged as "fake-sdaccel-builder" I think this is useful as it'll be picked up by fake-batch automatically per a commit that I've... made in another branch. Hmm. Some organisational work to be done here. |
* build fake-sdaccel-builder image for fake-batch testing
* build fake-sdaccel-builder image for fake-batch testing
Type of change
Description
Review Checklist
Goals
Does it solve the problem?
Is it the simplest implementation of that solution?
Does it yak shave? Does it introduce new dependencies that aren't necessary?
Does it decrease modularity?
Does the user of a module need to import another module to use this one?
If we want to delete these changes, how easy is that?
Does it clarify our domain?
What things does it refine? What things get added? How does this pave the way for new things?
Are things named in such a way that a domain expert can find them?
Does it introduce non-domain concepts?
What does the user of this need to learn outside of our domain in order to use this?
Testing
Do we integration test changes to external services?
Do we unit test code we can change?