move cron cloudwatch log name watcher up near cron #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
CampGareth
pushed a commit
that referenced
this pull request
Sep 18, 2018
CampGareth
pushed a commit
that referenced
this pull request
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Depends on #271
Cron has a few functions for looking at AWS Batch Jobs and pulling out the Cloudwatch LogName from them. This is done because the LogName will never expire while the Batch Job eventually will, leaving us unable to retrieve logs for that job. The functions were only used by Cron so I moved them up to Cron's level rather than have them clutter up interfaces.
Review Checklist
Goals
Does it solve the problem?
Is it the simplest implementation of that solution?
Does it yak shave? Does it introduce new dependencies that aren't necessary?
Does it decrease modularity?
Does the user of a module need to import another module to use this one?
If we want to delete these changes, how easy is that?
Does it clarify our domain?
What things does it refine? What things get added? How does this pave the way for new things?
Are things named in such a way that a domain expert can find them?
Does it introduce non-domain concepts?
What does the user of this need to learn outside of our domain in order to use this?
Testing
Do we integration test changes to external services?
Do we unit test code we can change?